Remove the octomap package from Rolling. #42561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is essentially a vendor package; upstream is not a ROS package, even though it has some things in it to interoperate with ROS. The problem is that it is *also* packaged in debian as a system package. In Ubuntu 24.04, the system version of the package has a different ABI than this "vendored" version. So it turns out that we don't need this version at all. All downstream sources have been updated to use the system version of the package, rather than this vendor. All but Moveit have done releases into Rolling as of this writing, so everything should continue to work with the exception of Moveit. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
github-actions
bot
added
the
rolling
mjcarroll
approved these changes
Aug 23, 2024
|
I'm going ahead and merging this one in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a vendor package; upstream is not a ROS package, even though it has some things in it to interoperate with ROS.
The problem is that it is also packaged in debian as a system package. In Ubuntu 24.04, the system version of the package has a different ABI than this "vendored" version.
So it turns out that we don't need this version at all. All downstream sources have been updated to use the system version of the package, rather than this vendor. All but Moveit have done releases into Rolling as of this writing, so everything should continue to work with the exception of Moveit.
This should fix #41622 .
@nuclearsandwich @wxmerkt FYI