Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3-validators to rosdistro #43485

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update configuration for different ubuntu version
Signed-off-by: Barry Xu <barry.xu@sony.com>
Barry-Xu-2018 committed Nov 18, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 4a2f54ca163914d9fc82eb27d540800ea3681959
9 changes: 8 additions & 1 deletion rosdep/python.yaml
Original file line number Diff line number Diff line change
@@ -10256,7 +10256,14 @@
python3-validators:
debian: [python3-validators]
fedora: [python3-validators]
ubuntu: [python3-validators]
ubuntu:
'*': [python3-validators]
bionic:
pip:
packages: [validators]
focal:
pip:
packages: [validators]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bionic is un-supported so we shouldn't add handling for it. Focal is nearly EOL so I think it's not worth adding unless you're actually using it.

Suggested change
bionic:
pip:
packages: [validators]
focal:
pip:
packages: [validators]

python3-vcstool:
alpine: [vcstool]
debian: [python3-vcstool]
@@ -10341,7 +10348,7 @@
ubuntu:
pip:
packages: [waymo-open-dataset-tf-2-6-0]
python3-weasyprint-pip:

Check warning on line 10351 in rosdep/python.yaml

GitHub Actions / rosdistro / rosdep checks (3.8)

Key 'python3-validators' might be satisfied by opensuse package named 'python3-validators': https://software.opensuse.org/package/python-validators
debian:
pip:
packages: [weasyprint]