Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feetech_ros2_driver: 0.1.0-1 in 'rolling/distribution.yaml' [bloom] #43490

Closed
wants to merge 1 commit into from

Conversation

JafarAbdi
Copy link
Contributor

Increasing version of package(s) in repository feetech_ros2_driver to 0.1.0-1:

feetech_ros2_driver

* Add feetech ros2 driver
* Contributors: Jafar Uruç

@github-actions github-actions bot added the rolling Issue/PR is for the ROS 2 Rolling distribution label Nov 13, 2024
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New package review checklist

Left a comment to consider and will wait for secondary approval from @sloretz before we merge this.

release:
tags:
release: release/rolling/{package}/{version}
url: https://github.com/JafarAbdi/feetech_ros2_driver-release.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to consider housing the release repo in the ros2-gbp org instead? The advantage there is that your package will automatically be available in the next ROS 2 distribution on release day.
https://docs.ros.org/en/rolling/How-To-Guides/Releasing/First-Time-Release.html#create-a-new-release-repository

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yadunund Do you mind taking a look at ros2-gbp/ros2-gbp-github-org#663? Thanks!

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For rolling packages, the release repository must be housed in the ros2-gbp organization.

@clalancette clalancette added more information needed Maintainers have asked for additional information changes requested Maintainers have asked for changes to the pull request and removed more information needed Maintainers have asked for additional information labels Nov 21, 2024
Copy link

github-actions bot commented Dec 6, 2024

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added stale Issue/PR hasn't been active in a while and may be closed. and removed stale Issue/PR hasn't been active in a while and may be closed. labels Dec 6, 2024
@JafarAbdi
Copy link
Contributor Author

Please review #43994 instead

@JafarAbdi JafarAbdi closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants