Run rosdistro-reviewer in target repository context #43606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the `pull_request` event, we can't use `write` permissions on the target repository, probably because the submitter could change the action as part of their PR. The `pull_request_target` event runs the action with the target repository's state instead of the PR's merged state. This will make testing changes to the automation a little more difficult, but also means that the automation no longer requires approval to run for first-time submitters. Because the checkout operation now fetches the PR target's HEAD, we need to explicitly fetch the PR's HEAD (but not check it out) so that the automation can inspect the git tree to find the changes.
nuclearsandwich
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
pull_requestevent, we can't usewritepermissions on the target repository, probably because the submitter could change the action as part of their PR.The
pull_request_targetevent runs the action with the target repository's state instead of the PR's merged state. This will make testing changes to the automation a little more difficult, but also means that the automation no longer requires approval to run for first-time submitters.Because the checkout operation now fetches the PR target's HEAD, we need to explicitly fetch the PR's HEAD (but not check it out) so that the automation can inspect the git tree to find the changes.
Follow-up to #42309