Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3-gtts #44037

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Add python3-gtts #44037

merged 2 commits into from
Dec 30, 2024

Conversation

Tacha-S
Copy link
Contributor

@Tacha-S Tacha-S commented Dec 25, 2024

Please add the following dependency to the rosdep database.

Package name:

python3-gtts

Package Upstream Source:

https://github.com/pndurette/gTTS

Purpose of using this:

I will use it as a basic text-to-speech feature.

Distro packaging links:

@Tacha-S Tacha-S requested a review from a team as a code owner December 25, 2024 05:11
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Dec 25, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ❌ There are problems with explicitly provided platforms:
    • One or more explicitly provided platforms are no longer supported

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

rosdep/python.yaml Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ✅ Platforms for new rosdep rules are valid

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@audrow audrow merged commit adca2a0 into ros:master Dec 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants