avoid adding notify waitable twice to events-executor collection #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
alsora
changed the title
|
CI:
|
rclcpp/src/rclcpp/experimental/executors/events_executor/events_executor.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
fujitatomoya
approved these changes
Jun 22, 2024
|
|
wjwwood
approved these changes
Jun 25, 2024
|
The
EDIT: try again, although this seems very flaky
|
|
Merging with green CI. |
apojomovsky
pushed a commit
to apojomovsky/rclcpp
that referenced
this pull request
Jul 8, 2024
…2#2564) * avoid adding notify waitable twice to events-executor entities collection Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com> * remove redundant mutex lock Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com> --------- Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug noticed by @wjwwood as part of his PR here
We don't need to add the notify waitable to the current entities collection list there, because it has already been added in the constructor.
The PR includes a unit-test that would detect bugs if the constructor insertion was removed.