Enhanced explanation on ROS 2 main function #5985
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expanded explanation of the main function and ROS 2 initialization process. Signed-off-by: Arashdeep Singh <147547278+ArashdeepSinghMaan@users.noreply.github.com>
ahcorde
requested changes
Nov 4, 2025
source/Tutorials/Beginner-Client-Libraries/Writing-A-Simple-Cpp-Publisher-And-Subscriber.rst
Outdated
Show resolved
Hide resolved
…p-Publisher-And-Subscriber.rst Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Arashdeep Singh <147547278+ArashdeepSinghMaan@users.noreply.github.com>
fujitatomoya
requested changes
Nov 5, 2025
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
github workflow is not happy, can you check the followings?
https://github.com/ros2/ros2_documentation/actions/runs/19070568079/job/54471988670?pr=5985
https://github.com/ros2/ros2_documentation/actions/runs/19070568079/job/54471988719?pr=5985
|
|
||
| Following the ``MinimalPublisher`` class is ``main``, where the node actually executes. | ||
| ``rclcpp::init`` initializes ROS 2, and ``rclcpp::spin`` starts processing data from the node, including callbacks from the timer. | ||
| ``rclcpp::init`` initializes ROS 2, and ``rclcpp::spin`` starts processing data from the node, including callbacks from the timer. The ``main()`` function begins by calling ``rclcpp::init(argc, argv);`` which initializes the ROS 2 client library. |
Collaborator
There was a problem hiding this comment.
single sentence per line.
Suggested change
| ``rclcpp::init`` initializes ROS 2, and ``rclcpp::spin`` starts processing data from the node, including callbacks from the timer. The ``main()`` function begins by calling ``rclcpp::init(argc, argv);`` which initializes the ROS 2 client library. | |
| ``rclcpp::init`` initializes ROS 2, and ``rclcpp::spin`` starts processing data from the node, including callbacks from the timer. | |
| The ``main()`` function begins by calling ``rclcpp::init(argc, argv);`` which initializes the ROS 2 client library. |
ahcorde
requested changes
Nov 10, 2025
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
Please @ArashdeepSinghMaan address the feedback related with CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded explanation of the main function and ROS 2 initialization process.
Description
Fixes # (issue)
Did you use Generative AI?
Additional Information