Fix constant generation for C++ floats #772
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a package, I came across a build warning on Windows that said:
After looking into it, I realized that the problem was that when we generate float constants for C++, the value we assign to it is a double, not a float. For instance, given the Constants.msg file, we currently generate (truncated for brevity):
But that is not quite right; that first line should be:
Interestingly, the warning only shows up when assigning certain constants to the float, like 0.05.
So this PR does three things:
f
as appropriate.