Address #775: Really make char in python a str
#781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses #775 for rolling going forward Note: This commit breaks a lot of down stream stuff. I will be pushing fixes one by one as I discover errors Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
arjo129
added a commit
to ros2/system_tests
that referenced
this pull request
Jan 4, 2024
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
arjo129
added a commit
to ros2/rosidl_runtime_py
that referenced
this pull request
Jan 4, 2024
Depends on ros2/rosidl#781 Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
arjo129
added a commit
to ros2/rclpy
that referenced
this pull request
Jan 4, 2024
Depends on ros2/rosidl#781 Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
|
The fix here looks good to me! Let me know when they're ready and I'll review them all at once. |
|
While I think this is the right thing to do, this is probably going to cause some heartache on downstream consumers. To that end, I think we should be loud about the change. So I'll request that you please open up a PR to update http://docs.ros.org/en/rolling/Releases/Release-Jazzy-Jalisco.html with details of this change so that users who are switching to Jazzy are aware. |
Signed-off-by: Arjo Chakravarty <arjoc@google.com>
Signed-off-by: Arjo Chakravarty <arjoc@google.com>
This PR will cause a lot of pain to downstream users. Signed-off-by: Arjo Chakravarty <arjoc@google.com>
Signed-off-by: Arjo Chakravarty <arjoc@google.com>
|
I don't think this change is worth it as downstream users will be left with a lot of "busy work" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses #775 for rolling going forward.
Note: This commit breaks a lot of down stream tests. I will be pushing fixes one by one as I discover errors.