Improve deprecation notice of rosidl_target_interface to give a hint on how to update the code #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on how to update the code Signed-off-by: Alexis Paques <paa1ti@bosch.com>
AlexisTM
requested review from
adityapande-1995,
methylDragon,
quarkytale and
sloretz
as code owners
mjcarroll
approved these changes
Feb 28, 2024
|
I ran into this recently, this is a very helpful addition. |
|
CI:
|
|
All of the failing tests here are also failing on the nightlies, so going ahead and merging this one. |
AlexisTM
deleted the
feature/improve_rosidl_target_interfaces_deprecation_notice
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a code example on how to fix the deprecation notice of rosidl_target_interface
The new message looks like:
