Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types rosidl_pycommon #824

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Add types rosidl_pycommon #824

merged 4 commits into from
Sep 13, 2024

Conversation

InvincibleRMC
Copy link
Contributor

No description provided.

@InvincibleRMC
add types
badbe75 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
fujitatomoya
fujitatomoya approved these changes Sep 4, 2024
View reviewed changes
Copy link

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

@sloretz
Copy link
Contributor

sloretz commented Sep 6, 2024

Pulls: #824
Gist: https://gist.githubusercontent.com/sloretz/0f352e57a108469388c8434da83a22e1/raw/7ff3c0c4429d640e4c290813d46a48160ed5a644/ros2.repos
BUILD args: --packages-up-to rosidl_pycommon
TEST args: --packages-select rosidl_pycommon
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14527

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
use hasattr check
9bbca00 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
flake8
2dcbfd5 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@adityapande-1995
Copy link

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
use str instead
c428d02 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@sloretz
Copy link
Contributor

sloretz commented Sep 12, 2024

@Mergifyio update

@mergify Mergify
Copy link

mergify bot commented Sep 12, 2024

update

☑️ Nothing to do

  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position = -1 [📌 update requirement]

@sloretz
Copy link
Contributor

sloretz commented Sep 12, 2024

Pulls: #824
Gist: https://gist.githubusercontent.com/sloretz/e1b7a8cc64fe43c3b17039be2246c766/raw/7ff3c0c4429d640e4c290813d46a48160ed5a644/ros2.repos
BUILD args: --packages-up-to rosidl_pycommon
TEST args: --packages-select rosidl_pycommon
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14552

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@sloretz
Copy link
Contributor

sloretz commented Sep 12, 2024

Pulls: #824
Gist: https://gist.githubusercontent.com/sloretz/e19f27055b212d0a7fbffc1a56c1ca77/raw/7ff3c0c4429d640e4c290813d46a48160ed5a644/ros2.repos
BUILD args: --packages-up-to rosidl_pycommon rosidl_generator_c rosidl_generator_cpp rosidl_typesupport_introspection_c rosidl_typesupport_introspection_cpp
TEST args: --packages-select rosidl_pycommon rosidl_generator_c rosidl_generator_cpp rosidl_typesupport_introspection_c rosidl_typesupport_introspection_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14553

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@sloretz
Copy link
Contributor

sloretz commented Sep 13, 2024

Thank you for the PR!

@sloretz sloretz merged commit c027a38 into ros2:rolling Sep 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

@adityapande-1995 adityapande-1995 adityapande-1995 approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

@quarkytale quarkytale Awaiting requested review from quarkytale quarkytale is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@InvincibleRMC @sloretz @adityapande-1995 @fujitatomoya