New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve export helpers method, enrich exception inf #94

Merged

asgeirrr merged 2 commits into rossumai:main from valtervojta:main

Jan 20, 2025

valtervojta commented Jan 17, 2025

Per EXE-2704.

Both export methods were not allowing filters, fixed that.
Some clients use more information from the exception and were wrapping APIClientError, which was unfortunate. Let me know if I should reformat it somehow, there is definitely wiggle room on this change.


          feat: Add support for filters in export helper methods

8a94d6f

valtervojta force-pushed the main branch 2 times, most recently from c91eef1 to 5c74ea3 Compare

January 17, 2025 14:40


          feat: Add more information to APIClientError

53d0781

valtervojta force-pushed the main branch from 5c74ea3 to 53d0781 Compare

January 17, 2025 14:53

asgeirrr approved these changes

View reviewed changes

Collaborator

asgeirrr left a comment

Very nice, it's always better to provide more info about an error 👍

asgeirrr merged commit 1adf1d1 into rossumai:main

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet