This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
fix: external pagination, and sticky table header #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelsos
reviewed
Dec 28, 2023
example/cypress/e2e/data-table.cy.ts
Outdated
| @@ -196,35 +196,38 @@ describe('DataTable', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('checks for data tables with sticky header', () => { | |||
| cy.get('div[data-cy=table-expandable-0]').as('sticky'); | |||
| it.only('checks for data tables with sticky header', () => { | |||
There was a problem hiding this comment.
I guess only was so that you could check the test? for CI it should be removed though.
There was a problem hiding this comment.
Was for me to easily test on local... will remove it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #(issue_number)