Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

fix(AutoComplete): fix UX to open menu after autocomplete focus #218

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

lukicenturi
Copy link
Contributor

Closes #(issue_number)

@lukicenturi lukicenturi requested a review from a team as a code owner June 25, 2024 12:41
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@4d7bff9). Learn more about missing BASE report.

Files Patch % Lines
...components/forms/auto-complete/RuiAutoComplete.vue 33.33% 10 Missing ⚠️
src/composables/dropdown-menu.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage        ?   67.62%           
=======================================
  Files           ?      108           
  Lines           ?    19023           
  Branches        ?      728           
=======================================
  Hits            ?    12865           
  Misses          ?     6158           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukicenturi lukicenturi force-pushed the fix-autocomplete-focus branch 3 times, most recently from 87decc5 to 76b99e4 Compare June 25, 2024 13:17
@lukicenturi lukicenturi force-pushed the fix-autocomplete-focus branch from 76b99e4 to faf8950 Compare June 25, 2024 13:18
Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kelsos kelsos merged commit faf8950 into rotki:main Jun 25, 2024
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants