Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

feat: export StepperIcon component #98

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

lukicenturi
Copy link
Contributor

Closes #(issue_number)

@lukicenturi lukicenturi requested a review from a team as a code owner December 23, 2023 07:44
@kelsos
Copy link
Member

kelsos commented Dec 23, 2023

@lukicenturi what are you going to do with the exported stepper icon?

@lukicenturi
Copy link
Contributor Author

@lukicenturi what are you going to do with the exported stepper icon?

I need to use custom-icon slot, so I can add the progress bar there
image

@kelsos
Copy link
Member

kelsos commented Dec 26, 2023

Can't we integrate what are you trying to do in the stepper itself instead of exporting the StepperIcon and implementing externally?

@lukicenturi
Copy link
Contributor Author

Can't we integrate what are you trying to do in the stepper itself instead of exporting the StepperIcon and implementing externally?

okay I think I'll just add loading to the step data.

@kelsos
Copy link
Member

kelsos commented Dec 28, 2023

Great, don't forget to also create PRs with these changes, and the RuiButton list changes to the main library. I tried to do a rebase of the vue 3 branch and we are also missing that :)

Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kelsos kelsos merged commit 3164265 into rotki:main Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants