Upgrade ruby version and timezone info #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aviyam! Thanks for the PR. I see you've closed it - did you manage to get Build Window running without the changes? |
|
I managed to run it with my changes, but I noticed that Travis testing
failed. I'm a noob at Ruby projects, so at the moment, I decided I better
close this PR untill I figure how to make the tests pass.
…On Mon, Feb 11, 2019, 16:30 Rouan Wilsenach ***@***.***> wrote:
Hi @aviyam <https://github.com/aviyam>! Thanks for the PR. I see you've
closed it - did you manage to get Build Window running without the changes?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEUj-QWItHz3hzoAjybRaOT1xsEDgnNnks5vMX6YgaJpZM4az9zp>
.
|
|
@aviyam don't worry about that, it's been a couple of years since I've done much in Ruby! 😄 I've simplified the Dockerfile on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfile was referring to an older version of Ruby. Bundler version was not compatible with it. Upgraded.
When running the docker file an error regarding Timezone info appeared. The solution was to add the tzinfo-data gem installed as well.