Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying the gemlock file and enabling building status on jenkins #4

Closed
wants to merge 4 commits into from

Conversation

brianleke
Copy link

I have added the possibility to display a yellow dashboard while the build is running for jenkins so that there is some visual feedback for the user. Also modified the gemfile as the latest version of coffee-script-source 1.10.0 or 1.9.0 does not work on windows systems so have dropped the version to 1.8.0.

@rouanw
Copy link
Owner

rouanw commented Feb 17, 2016

Thanks @brianleke. Two things before we merge:

CoffeeScript dependency

It's best practice not to edit the Gemfile.lock file manually. Rather set the coffee-script-source version in the Gemfile:

gem 'coffee-script-source', '= 1.8.0'

See this question on StackOverflow.

You can then get bundler to update the lock file for you automatically:

bundle update coffee-script-source

Building status

I like the fact that your changes provide a visual cue that the build is currently running, but it no longer tells you the status of the most recently completed build. As a team member, I'd like to know whether the previous build passed or failed, so I can decide whether or not to push my code.

Perhaps you can provide a visual indication of the fact that a build is running without using the current status property? (That way the build window can still say 'successful' or 'failed' and be green or red, based on the most recent status.) I think the simplest thing would be to show a 'running' gif or apply a CSS animation (like Build Reactor) to the build window while the build is running, based on a building property.

@rouanw
Copy link
Owner

rouanw commented Mar 9, 2016

Hi @brianleke. I'm going to close this PR for now. It would be great if you could open a separate PR for the Windows support, so I can merge that so long. Then you can also submit a PR with the 'building' functionality when you're ready. Thanks man!

@rouanw rouanw closed this Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants