Initial Docker support #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great stuff. Thanks @stefanteixeira. I've created an automated build for this repo on docker hub - https://hub.docker.com/r/rouanw/build-window. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR includes Docker support for build-window. I created a Dockerfile from an official Ruby 2.1.8 minimal base image (which uses Alpine Linux). I'm aware that the project was built in Ruby 2.1.3, but unfortunately the official Ruby repository only provides 2.1.8 images (https://hub.docker.com/_/ruby/).
To make things more simple, I included a Docker Compose file, which builds an image using the mentioned Dockefile, maps host/container ports (3030 and 3031) and runs
dashing start.I'm currently using this at my company and it's working nicely. We are still looking for the best way to manage dashboard changes using volumes, so I plan to create a new PR in a few weeks to improve that. Either way, I thought that an initial Docker support would be helpful for new users :)
Thanks!
Stefan