-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development #132
Draft
Jsoto22
wants to merge
16
commits into
Rel/2024-04-m1
Choose a base branch
from
development
base: Rel/2024-04-m1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Development #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows for any size Integer to be used as an exponent
Adds 'Euclidean division' Modulus operation and simplifies Modulus Remainder sign logic. Unit tests added.
Implements support for fractional exponents in powers and integer only roots
Adds new features and updates REAMDME.md Todo: expand unit testing for new features.
- Fixed typing issues in BigDecimal validate - Removed deprecated substr functions - Added wrapper logic functions to compareTo - Fully implemented 'UNNECESSARY' rounding mode
should close issue #57
todo: Unit testing
This was
linked to
issues
Apr 21, 2024
Open
- Bug fixes - Optimizations added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is preliminary and will be completed by the end of April 2024. Does not currently pass checks due to lines covered in unit testing. Please read notes at the end.
Additions:
E
,LN2
,LN2E
,LN10
, andLN10E
)Issues Addressed:
Drafting this PR for now until Todo list is completed.
Notes on approximations and performance
Nature of approximations
Many of the added functions utilize approximations where the precision is accurate up to ULP (Unit in the last place) of 1. The default precision is 32 decimal places and uses the default rounding mode when returning the result.
The approximations themselves utilize specific formulas and various types of mathematical series. For values close to one after argument reduction, convergence rates are relatively fast, although convergence rates for some functions will never truly converge for irrational numbers, as they can be infinitely approximated to any point of precision. To limit these operations, a tolerance within the desired precision is used as such:
The current
bigO
complexity has yet to be evaluated, but many of the algorithms have been modeled after IEEE 754 and other resources. More optimizations will likely be implemented, and evaluation of performance will follow.