Merge pull request #69 from royalfig/bugfix/menu

bugfixes
royalfig · Jul 17, 2021 · 6693033 · 6693033
2 parents 7c0d5ed + 886bf3c
commit 6693033
Show file tree

Hide file tree

Showing 11 changed files with 6,922 additions and 18 deletions.
diff --git a/assets/built/app.css b/assets/built/app.css
diff --git a/assets/built/app.js b/assets/built/app.js
diff --git a/assets/built/post.css b/assets/built/post.css
diff --git a/assets/built/post.js b/assets/built/post.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "smart",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "An elegant Ghost theme",
   "main": "index.js",
   "engines": {

diff --git a/partials/footer.hbs b/partials/footer.hbs
@@ -33,7 +33,7 @@
             {{#get "tags" include="count.posts" filter="name:-publications+name:-presentations+name:-teaching+name:-outreach+name:-dissertation" limit="10" order="count.posts desc"}}
             {{#if tags}}
             <div class="sm-footer__section">
-                <p class="footer__header--serif">Tags</p>
+                <p class="sm-footer__header--serif">Tags</p>
                 {{#foreach tags}}
                 <a class="sm-tag" href="{{url}}">{{name}}</a>
                 {{/foreach}}

diff --git a/partials/menu.hbs b/partials/menu.hbs
@@ -1,5 +1,5 @@
 {{! Mobile Nav Menu }}
-<nav class="sm-modal" id="sm-menu" aria-expanded="false">
+<nav class="sm-modal sm-menu" id="sm-menu" aria-expanded="false">
   <div class="sm-modal__container">
     <header class="sm-modal__header">
       <button class="sm-modal__close-btn" data-target="menu" aria-label="Close menu" tabindex="-1">

diff --git a/src/scss/base/_default.scss b/src/scss/base/_default.scss
@@ -34,8 +34,8 @@ em {
 }
 
 ::selection {
-  color: #111;
-  background-color: #e0c081;
+  color: var(--textInverse);
+  background-color: var(--secondary);
 }
 
 :target {

diff --git a/src/scss/layout/_container.scss b/src/scss/layout/_container.scss
@@ -22,12 +22,20 @@
     min-height: 250px;
     padding-bottom: 1rem;
 
-    .post-template &, .page-template &, .tag-template &, .author-template &,   {
+    .post-template &,
+    .page-template &,
+    .tag-template &,
+    .author-template & {
       padding-bottom: 3.5rem;
     }
 
     @media (min-width: variables.$laptop) {
-      padding-bottom: 1rem;
+      .post-template &,
+      .page-template &,
+      .tag-template &,
+      .author-template & {
+        padding-bottom: 1rem;
+      }
     }
 
     font-size: 0.9rem;

diff --git a/src/scss/layout/_footer.scss b/src/scss/layout/_footer.scss
@@ -8,7 +8,6 @@
   &__section {
     display: flex;
     flex-direction: column;
-    // padding: 0.5rem;
 
     &--latest {
       @extend .sm-footer__section;
@@ -60,7 +59,6 @@
   &__header--serif {
     margin-bottom: 0.5rem;
     font-size: 115%;
-    // @extend .serif;
   }
 
   &__social {

diff --git a/src/scss/layout/_menu.scss b/src/scss/layout/_menu.scss
@@ -2,7 +2,21 @@
 // Mobile Nav Menu
 //-------------------------------------------
 @use '../abstracts/mixins';
+@use '../abstracts/variables';
+
 .sm-menu {
+  .sm-modal__container {
+    padding: 1rem;
+
+    @media (min-width: variables.$tablet) {
+      padding: 1rem 3rem;
+    }
+
+    @media (min-width: variables.$laptop) {
+      padding: 1rem 4rem;
+    }
+  }
+
   &__link {
     @include mixins.transition(color);
     &:focus {