Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having the same problem as in issue #108, but I'd prefer not to have to create a custom resolver configuration for Nginx. Things are simpler if
entrypoint.sh
handles things and the container sorts itself out.This PR implements a check for the env variable and the appending of
ipv6=off
to the resolver string if appropriate. I've tried to keep it in line with your coding style elsewhere inentrypoint.sh
.There's also an addition to
README.md
regarding the variable, but I'm not sure what to do about the link I included there.I was initially looking at the
README.md
in PR #109, so I linked to theCustom nginx resolvers configuration
heading. That PR hasn't been merged yet, but I left the link in under the assumption it will become functional at some future point.I'm just not sure if that's the best way to go about things..? I'm happy to remove the link and rebase this PR if you'd like.