Allow the local plugin to exclude packages from the local cache repo #473
Conversation
| @@ -63,6 +64,8 @@ def parse_config(self): | |||
| else: | |||
| raise KeyError("Disabled") | |||
|
|
|||
| main["exclude"] = self.get_value("main", "exclude", "") | |||
There was a problem hiding this comment.
In the main configuration, we use the option "excludepks", it is documented as such and the alias "exclude" is there just for compatibility with yum. So, I would propose to either rename this as "excludepkgs", or to support both variants.
There was a problem hiding this comment.
Is the exclude field a true alias of excludepkgs? Or are they two separate fields that need to be read independently?
There was a problem hiding this comment.
|
It would also be nice to add a note about this option to the documentation ( https://github.com/rpm-software-management/dnf-plugins-core/blob/master/doc/local.rst ) even though the documentation of this plugin's config options is in a bad shape already. |
I will do some updating to the documentation. |
When using the local plugin as a cache for multiple guest machines, packages that might get installed in the guest that are ignored on the host will end up bypassing the
excludefilters in the repo configs on the host.This change allows the
excludeoption to be configured in the local plugin so that these packages will still be excluded from installation.