Add comps upgrade to system upgrade, comps improvements #2086
Conversation
We have to check for this otherwise the empty string cannot be converted to valid group package type.
kontura
force-pushed
the
system-upgrade-comps
branch
from
b134329 to
835841a
Compare
This would be problematic when we merge group/environment definitions from all availables repos. When a repo with some part of a group definition would be unavailable or disabled an upgrade would clear contained packages. This matches dnf4 behavior.
kontura
force-pushed
the
system-upgrade-comps
branch
from
835841a to
472aadb
Compare
| // If we have multiple different actions per group it always ends up as upgrade. | ||
| // This is because there are only 3 actions: INSTALL, UPGRADE and REMOVE, any two | ||
| // of them mean an UPGRADE. | ||
| // (Given that groups are not versioned the UPGRADE action basically means synchronization | ||
| // with currently loaded metadata.) |
There was a problem hiding this comment.
Hm, I am thinking if REMOVE + INSTALL should really be the same as UPGRADE, because when run sequentially, dnf removes the packages that were removed from a group. But maybe there is a viewpoint I am not considering? Also, I don't think it is a very frequent use case and I am not sure how feasible would it be to implement a different behavior.
| // Upgrade only userinstalled groups because dependency groups will be handled | ||
| // during environments upgrade. | ||
| // This is important beucase a group can be removed during environment upgrade | ||
| // and it should not be makred for upgrade. |
There was a problem hiding this comment.
So, an installed group won't get any updates if it was removed from an environment. I am not sure if this is a correct approach. I mean, when you have packages that are installed as dependencies, they still do get updates. Why wouldn't that be the same for groups?
Also, is this the change that you mentioned in the tests ("There is a change to dnf4 behavior where packages/groups that are no longer part of a group/environment are no longer upgraded. I am not sure if we want this change.")? Because the note suggests it applies also to packages that were removed from group, but the packages still are upgraded...
Closes: #1817
Test update: rpm-software-management/ci-dnf-stack#1641