offline transactions: Keep user informed about scriptlet execution #2087
+66
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-blaha
force-pushed
the
mblaha/system-upgrade-scriptlets
branch
7 times, most recently
from
e7b05ad to
f1d20bf
Compare
|
I believe this will resolve https://bugzilla.redhat.com/show_bug.cgi?id=2345905. |
m-blaha
force-pushed
the
mblaha/system-upgrade-scriptlets
branch
2 times, most recently
from
85e855f to
969d19a
Compare
It's '--ping', not 'ping'.
The `amount` parameter counts transaction items starting from 0, but for humans, it's more natural to start from 1.
Scriptlet execution can take a significant amount of time. Inform the user when it starts. Fixes: #1667
The mode is set to "system-upgrade" for upgrading to the next distribution version, and to "updates" for general offline transaction execution. Also the plymouth message is adjusted according to the mode. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2345905
This is definitely not exact (since there is no way to get the exact number of scriptlets going to be executed), but is should at least show some progress bar changes during the scriptlets execution.
m-blaha
force-pushed
the
mblaha/system-upgrade-scriptlets
branch
from
969d19a to
034e867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scriptlet execution can take a significant amount of time. Inform the user when
it starts.
Resolves: #1667