ConfigParser: fix use-out-of-scope leaks #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that with the changes a dnf test is failing. Specifically: https://github.com/rpm-software-management/dnf/blob/master/tests/conf/test_parser.py#L37 @evan-goode can you look into it? |
evan-goode
force-pushed
the
evan-goode/fix-use-out-of-scope
branch
from
f109acc
to
aed770e
Compare
Thanks, fixed. The tests should pass now. The same oversight was not present in the sister DNF 5 PR (rpm-software-management/dnf5#1473). |
kontura
merged commit 18f49a4
into
rpm-software-management:dnf-4-master
9 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address some use-out-of-scope bugs found during static analysis. Also ports a test for the shell-style variable expansion over from DNF 5.