Hash cache: Improved work with extended file attributes #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#define XATTR_CHKSUM_MTIME XATTR_CHKSUM_PREFIX "mtime" Before that, the code used: `timestamp_key = g_strconcat(XATTR_CHKSUM_PREFIX, "mtime", NULL);`
jan-kolarik
merged commit ba5365f
into
rpm-software-management:master
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR modifies the code so that if a function detects that user extended file attributes are not supported, it stops using them.
Note:
In that case, it does not call
flistxattr. Callingflistxattrcauses problems, so not calling it should solve those issues:The
flistxattrsystem call problem is also addressed in Linux kernel >=6.2:However, this patch is still useful and additionally solves the problem when using an older kernel.