Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: Correct setting -DENABLE_SELINUX cmake argument #319

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

ppisar
Copy link
Contributor

@ppisar ppisar commented Jul 11, 2024

%{?need_selinux:ON} always expanded to "ON" because %{?} tests whether a macro is defined. Not whether it is true.

The fixed problem is so far only cosmetic becasue CMakeLists.txt ignores ENABLE_SELINUX if USE_GPGME cannot be enabled.

%{?need_selinux:ON} always expanded to "ON" because %{?} tests whether
a macro is defined. Not whether it is true.

The fixed problem is so far only cosmetic becasue CMakeLists.txt
ignores ENABLE_SELINUX if USE_GPGME cannot be enabled.
@ppisar
Copy link
Contributor Author

ppisar commented Jul 11, 2024

Python tests also fail because of it. I will amend them.

@ppisar ppisar marked this pull request as draft July 11, 2024 08:14
@ppisar ppisar marked this pull request as ready for review July 11, 2024 09:12
@ppisar
Copy link
Contributor Author

ppisar commented Jul 11, 2024

I fixed also the Python test.

@ppisar
Copy link
Contributor Author

ppisar commented Jul 11, 2024

Ignore the last two comments. They belonged to #320.

Copy link
Member

@m-blaha m-blaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@m-blaha m-blaha merged commit c369866 into rpm-software-management:master Jul 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants