Fix memory leaks when using zchunk #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabled by default, only for debugging. When using it it may be required to manually preload: `LD_PRELOAD=/usr/lib64/libasan.so.8` for the client process. This is because ASan runtime requires to be first in initial library list.
Since the `zckCtx` from `zckDL` is referenced only in `zckDL` and there is only a single `zckDL` per `LrDownloadTarget` we have to free previous `zckCtx` before overwriting it. Otherwise it leaks.
jan-kolarik
reviewed
Aug 1, 2024
Apart from these two places the `zck_dl` is leaking through other code paths. Handle it and stuff it contains in a single place.
jan-kolarik
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also adds a cmake option to build with sanitizers.