-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix example16: minor changes to magnification axis #120
Bugfix example16: minor changes to magnification axis #120
Conversation
f3f47b3
to
d0b1f48
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #120 +/- ##
=======================================
Coverage 83.52% 83.52%
=======================================
Files 52 52
Lines 8318 8318
=======================================
Hits 6948 6948
Misses 1370 1370
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please remove Also please change version to 0.34.4. |
@rpoleski To make sure I don't forget and since this second Y-axis has a different scale, I created a small function to handle its minor ticks. I already changed the version, but I'm open to suggestions! |
A few more changes are needed:
|
@rpoleski Done! |
|
Minor changes were applied to the magnification second Y-axis, as suggested by Jason. I changed the color to
'black'
, label to 'Magnifications' and ticks to'inside'
.Minor ticks (as in issue #118) were left for the future, since the axis scale is neither linear or log.