Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix example16: minor changes to magnification axis #120

Merged
merged 7 commits into from
Mar 18, 2024

Conversation

rapoliveira
Copy link
Contributor

Minor changes were applied to the magnification second Y-axis, as suggested by Jason. I changed the color to 'black', label to 'Magnifications' and ticks to 'inside'.

Minor ticks (as in issue #118) were left for the future, since the axis scale is neither linear or log.

@rapoliveira rapoliveira marked this pull request as draft January 18, 2024 15:51
@rapoliveira rapoliveira marked this pull request as ready for review January 18, 2024 15:52
@rapoliveira rapoliveira force-pushed the bugfix-example16-residuals branch from f3f47b3 to d0b1f48 Compare January 18, 2024 15:58
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.52%. Comparing base (6fabea2) to head (959f353).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   83.52%   83.52%           
=======================================
  Files          52       52           
  Lines        8318     8318           
=======================================
  Hits         6948     6948           
  Misses       1370     1370           
Flag Coverage Δ
unittests 83.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rpoleski
Copy link
Owner

Please remove # , minor=True) due to Jen's rule no. 1: "Don't leave unused code".

Also please change version to 0.34.4.

@rapoliveira
Copy link
Contributor Author

@rpoleski To make sure I don't forget and since this second Y-axis has a different scale, I created a small function to handle its minor ticks. I already changed the version, but I'm open to suggestions!

@rpoleski
Copy link
Owner

rpoleski commented Mar 4, 2024

A few more changes are needed:

  • _mark_second_Y_axis_in_best_plot() got quite long, so please split it into shorter functions (Jen's rule no. 2: "Functions should be shorter than 20 lines.",
  • name of variable sb_fluxes is unclear to me (and not explained in docstings) - please modify it.

@rapoliveira
Copy link
Contributor Author

@rpoleski Done!

@rpoleski
Copy link
Owner

rpoleski commented Mar 8, 2024

sb_fluxes -> ref_fluxes in _second_Y_axis_minor_ticks() and it will be finished.

@rpoleski rpoleski merged commit cc365ed into rpoleski:master Mar 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants