-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive plots #154
Interactive plots #154
Conversation
Good to see first pass, which already looks quite good. I'll have a deeper look into it.
|
|
I have split some longer functions. The longest function right now is |
I also added a warning when the interactive plot and second Y axis is selected. |
In 7d465f3 I've corrected order of functions. While doing so, I've found that |
In the last commit I've simplified the code by reducing duplicated statements. Please try to remove copy-pasted code in a similar way. |
Also I see that from |
Are you sure the return statements in |
Two more minor things:
|
Please see Semantic Versioning rules. |
I added an option for creating interactive plots for the best model using Plotly. An interactive plot will be created if the YAML file includes: 'plots': 'best model': 'interactive': file.html. Some settings for the interactive plot are inherited from the regular plot, while others are defined within ulens_model_fit.py. Although some new functions are quite long, I am concerned that splitting them into smaller ones would make adjusting interactive plot settings a non-trivial task for users.