Issue #94: proposed 1L2S get_trajectory bug fixes

[jenniferyee]

Proposed bug fixes for Model.get_trajectory() and FitData.get_dataset_trajectory(). Also updated Ex 17 to include plotting of 1L2S trajectory figure and added unittests for Model.get_trajectory() and FitData.get_dataset_trajectory(). These unit tests currently fail. We need to update the reference files to include trajectory X, Y, first.

[jenniferyee]

Specifically, what is needed:

SAMPLE_FILE_03_REF = join(dir_2, 'ob140939_Spitzer_ref_v1.dat')

Needs columns ADDED for Spitzer source trajectory X and Y positions as in

ref_Spitzer = np.loadtxt(SAMPLE_FILE_03_REF, unpack=True)
ratio_x = trajectory.x / ref_Spitzer[6]
ratio_y = trajectory.y / ref_Spitzer[7]

[rpoleski]

@jenniferyee I would just test against values returned by current code - are you ok with that? It'll take me relatively long to get them from independent code like sfit.

[codecov-commenter]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (537e33c) 83.45% compared to head (bf40fcb) 83.63%.
Report is 12 commits behind head on master.

Files	Patch %	Lines
source/MulensModel/model.py	90.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   83.45%   83.63%   +0.18%     
==========================================
  Files          52       52              
  Lines        8176     8269      +93     
==========================================
+ Hits         6823     6916      +93     
  Misses       1353     1353              

Flag	Coverage Δ
unittests	83.63% <99.01%> (+0.18%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rpoleski]

Without running the code, I see that Model.get_trajectory() should have satellite_skycoord keyword describe. It's a new aspect of API, so we should change the version to 2.19.

[rpoleski]

Model.get_trajectory() docstrings need updates:

1. satellite_skycoord has to be described
2. returned type for binary source has to be given.

Everything else is OK.

[jenniferyee]

HOORAY! -------------------------------------------------------------- Dr. Jennifer C. Yee (she/her) Office: P-341 Center for Astrophysics | Harvard & Smithsonian 60 Garden St, MS-15 Cambridge, MA 02138 --------------------------------------------------------------

…

On Thu, Dec 7, 2023 at 9:53 AM Radek Poleski ***@***.***> wrote: Merged #98 <#98> into master. — Reply to this email directly, view it on GitHub <#98 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEK7UCJATSDXCBREFAPUPRLYIHJ7ZAVCNFSM6AAAAAA5BZBCBGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGE4DGMBUGA3TENY> . You are receiving this because you were mentioned.Message ID: ***@***.***>