login in a dedicated step

rrey · Jun 20, 2020 · f7acf6c · f7acf6c
1 parent a6bedf9
commit f7acf6c
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -13,13 +13,14 @@ jobs:
     - name: Build the Docker image
       run: docker build . --file Dockerfile --tag rrey/terraform-runner:$(git tag --points-at HEAD)
 
-    - name: Push the image
-      run: |
-          docker login -u rrey -p $DOCKERHUB_TOKEN
-          docker push rrey/terraform-runner:$(git tag --points-at HEAD)
+    - name: login to dockerhub
+      run: docker login -u rrey -p $DOCKERHUB_TOKEN
       env:
         DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
 
+    - name: Push the image
+      run: |
+          docker push rrey/terraform-runner:$(git tag --points-at HEAD)
 
   azdo-build:
     runs-on: ubuntu-latest
@@ -29,9 +30,11 @@ jobs:
     - name: Build the Docker image
       run: docker build . --build-arg BASE_IMG=rrey/azdo-base-container:v0.1.2 --file Dockerfile --tag rrey/terraform-runner:$(git tag --points-at HEAD)-azdo
 
-    - name: Push the image
+    - name: login to dockerhub
       run: |
           docker login -u rrey -p $DOCKERHUB_TOKEN
-          docker push rrey/terraform-runner:$(git tag --points-at HEAD)-azdo
       env:
         DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
+
+    - name: Push the image
+      run: docker push rrey/terraform-runner:$(git tag --points-at HEAD)-azdo