Skip to content

Commit

Permalink
[Security Solution] Copies over settings from timeline template (elas…
Browse files Browse the repository at this point in the history
…tic#190511)

## Summary

Handles : elastic#189992

When user had created a timeline template and attached it to the rule,
the columns were not being copied over from template to the timeline
created from the alert generated by same rule.

This PR fixes that as shown in demo below : 


https://github.com/user-attachments/assets/4237672e-943a-43f9-b160-5449399a5fd8

> [!Caution]
> This PR checks below objects that are needed to be copied over from
template
> - columns
> - data providers
>
> If we think, more things should be copied over, please comment below.

## Test Results


![grafik](https://github.com/user-attachments/assets/ad527eda-a1c2-49f0-bcfe-0ea449c29b34)



### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
  • Loading branch information
logeekal authored Aug 14, 2024
1 parent b336eec commit a13f8d9
Show file tree
Hide file tree
Showing 3 changed files with 332 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1085,7 +1085,9 @@ export const sendAlertToTimelineAction = async ({
});
}
}
} catch {
} catch (error) {
/* eslint-disable-next-line no-console */
console.error(error);
updateTimelineIsLoading({ id: TimelineId.active, isLoading: false });
return createTimeline({
from,
Expand Down
Loading

0 comments on commit a13f8d9

Please sign in to comment.