Copy fix and remove extra flex wrappers

rshen91 · Jan 2, 2024 · b535350 · b535350
1 parent 8d629c9
commit b535350
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 29 deletions.
diff --git a/src/plugins/share/public/components/modals/embed_modal_page.tsx b/src/plugins/share/public/components/modals/embed_modal_page.tsx
@@ -395,20 +395,6 @@ export const EmbedModal: FC<EmbedModalPageProps> = (props: EmbedModalPageProps)
                 />
               </EuiFlexItem>
             </EuiFlexGroup>
-            {/* <EuiSpacer size="m" />
-            <EuiFlexGroup> */}
-              {/* {props.urlParamExtensions && props.urlParamExtensions?.map(({paramName}) => { */}
-              {/* <EuiButton fill onClick={() => setParamValue('embed')}>
-                <FormattedMessage id="share.embed.embedButton" defaultMessage="Copy Embed" />
-              </EuiButton> */}
-              {/* })} */}
-            {/* </EuiFlexGroup>
-            <EuiSpacer size="m" />
-            <EuiFlexGroup direction="row" justifyContent="flexEnd">
-              <EuiButton fill onClick={onClose}>
-                <FormattedMessage id="share.embed.doneButton" defaultMessage="Done" />
-              </EuiButton>
-            </EuiFlexGroup> */}
           </EuiForm>
         </EuiModalBody>
         <EuiModalFooter>
@@ -423,7 +409,7 @@ export const EmbedModal: FC<EmbedModalPageProps> = (props: EmbedModalPageProps)
                 </EuiFlexItem>
                 <EuiFlexItem>
                   <EuiButton fill onClick={() => setParamValue('embed')}>
-                    <FormattedMessage id="share.embed.embedButton" defaultMessage="Copy Embed" />
+                    <FormattedMessage id="share.embed.embedButton" defaultMessage="Copy embed" />
                   </EuiButton>
                 </EuiFlexItem>
               </EuiFlexGroup>

diff --git a/src/plugins/share/public/components/modals/link_modal_page.tsx b/src/plugins/share/public/components/modals/link_modal_page.tsx
@@ -393,21 +393,17 @@ export const LinkModal: FC<LinksModalPageProps> = (props: LinksModalPageProps) =
           </EuiForm>
         </EuiModalBody>  
         <EuiModalFooter>
-          <EuiFlexGroup alignItems="center">
+          <EuiFlexGroup alignItems="center" gutterSize="m">
             <EuiFlexItem>{allowShortUrl && renderShortUrlSwitch()}</EuiFlexItem>
-            <EuiFlexItem grow={false}>
-              <EuiFlexGroup gutterSize="m">
-                <EuiFlexItem>
-                  <EuiButtonEmpty onClick={onClose}>
-                    <FormattedMessage id="share.links.doneButton" defaultMessage="Done" />
-                  </EuiButtonEmpty>
-                </EuiFlexItem>
-                <EuiFlexItem>
-                  <EuiButton fill onClick={() => copyLink()}>
-                    <FormattedMessage id="share.link.copyLinkButton" defaultMessage="Copy link" />
-                  </EuiButton>
-                </EuiFlexItem>
-              </EuiFlexGroup>
+            <EuiFlexItem grow={0}>
+              <EuiButtonEmpty onClick={onClose}>
+                <FormattedMessage id="share.links.doneButton" defaultMessage="Done" />
+              </EuiButtonEmpty>
+            </EuiFlexItem>
+            <EuiFlexItem grow={0}>
+              <EuiButton fill onClick={() => copyLink()}>
+                <FormattedMessage id="share.link.copyLinkButton" defaultMessage="Copy link" />
+              </EuiButton>
             </EuiFlexItem>
           </EuiFlexGroup>
         </EuiModalFooter>