Skip to content

Commit

Permalink
[Discover] Add baseline tests for time field column (elastic#176937)
Browse files Browse the repository at this point in the history
- Addresses elastic#174074

Adding tests before I change the code via
elastic#176834

It checks different permutations of the following conditions:
- with and without selected fields
- data view with and without a time field
- ESQL with and without a time field
- Discover and Dashboard views
- `doc_table:legacy` setting
- `doc_table:hideTimeColumn` setting

The whole test suite is running for ~23 minutes. Here is the successful
build
https://buildkite.com/elastic/kibana-pull-request/builds/193811#018dace6-044f-46f9-b7a9-1fc82d05278c

I am skipping some tests so it does not take so much time on every
Kibana build. If we ever need to check all edge cases (like in
elastic#176834) we can temporary enable
them again. So in the end the PR adds ~7 minutes to the build.
  • Loading branch information
jughosta authored Feb 20, 2024
1 parent 523e91b commit f004fac
Show file tree
Hide file tree
Showing 4 changed files with 459 additions and 0 deletions.
1 change: 1 addition & 0 deletions test/functional/apps/discover/group3/_default_columns.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await esArchiver.unload('test/functional/fixtures/es_archiver/kibana_sample_data_logs_tsdb');
await esArchiver.unload('test/functional/fixtures/es_archiver/kibana_sample_data_flights');
await kibanaServer.savedObjects.cleanStandardList();
await kibanaServer.uiSettings.replace({});
});

beforeEach(async function () {
Expand Down
Loading

0 comments on commit f004fac

Please sign in to comment.