Include check constraints in structure.sql #2214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would someone be able to help with the build failure please? I'm new here. |
@yahonda mind if I pick you? Can you please have a look at the red build here? Thanks in advance! |
|
CI failures are likely due to missing support rails/rails@d79fb96 . Now #2199 is opened but it needs to fix some other failures. |
|
I'd like to resolve #2199 first to merge other pull requests. |
Thanks a lot, I'll watch that |
|
Now #2199 has been merged to master branch, Would you rebase this pull request? |
benny-burkhart
force-pushed
the
check-constraints-structure-sql
branch
from
ff9ea3b
to
c497b56
Compare
|
This pull request needs updated not to fail this spec. $ bundle exec rspec ./spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:219
==> Loading config from ENV or use default
==> Running specs with ruby version 3.1.1
==> Effective ActiveRecord version 7.1.0.alpha
Run options: include {:locations=>{"./spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb"=>[219]}}
F
Failures:
1) OracleEnhancedAdapter structure dump structure dump should dump check constraints
Failure/Error: expect(dump).to eq(["ALTER TABLE FORM_SUBMISSIONS ADD CONSTRAINT FOO_IS_JSON CHECK (foo is json)"])
expected: ["ALTER TABLE FORM_SUBMISSIONS ADD CONSTRAINT FOO_IS_JSON CHECK (foo is json)"]
got: ["ALTER TABLE TEST_POSTS ADD CONSTRAINT FOO_IS_JSON CHECK (foo is json)"]
(compared using ==)
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-support-3.11.0/lib/rspec/support.rb:102:in `block in <module:Support>'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-support-3.11.0/lib/rspec/support.rb:111:in `notify_failure'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-expectations-3.11.0/lib/rspec/expectations/fail_with.rb:35:in `fail_with'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-expectations-3.11.0/lib/rspec/expectations/handler.rb:38:in `handle_failure'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-expectations-3.11.0/lib/rspec/expectations/handler.rb:56:in `block in handle_matcher'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-expectations-3.11.0/lib/rspec/expectations/handler.rb:27:in `with_matcher'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-expectations-3.11.0/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-expectations-3.11.0/lib/rspec/expectations/expectation_target.rb:65:in `to'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-expectations-3.11.0/lib/rspec/expectations/expectation_target.rb:101:in `to'
# ./spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:225:in `block (3 levels) in <top (required)>'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/example.rb:263:in `instance_exec'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/example.rb:263:in `block in run'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/example.rb:511:in `block in with_around_and_singleton_context_hooks'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/example.rb:468:in `block in with_around_example_hooks'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/hooks.rb:486:in `block in run'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/hooks.rb:624:in `run_around_example_hooks_for'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/hooks.rb:486:in `run'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/example.rb:468:in `with_around_example_hooks'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/example.rb:511:in `with_around_and_singleton_context_hooks'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/example.rb:259:in `run'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/example_group.rb:646:in `block in run_examples'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/example_group.rb:642:in `map'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/example_group.rb:642:in `run_examples'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/example_group.rb:607:in `run'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/example_group.rb:608:in `block in run'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/example_group.rb:608:in `map'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/example_group.rb:608:in `run'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/runner.rb:121:in `block (3 levels) in run_specs'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/runner.rb:121:in `map'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/runner.rb:121:in `block (2 levels) in run_specs'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/configuration.rb:2068:in `with_suite_hooks'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/runner.rb:116:in `block in run_specs'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/reporter.rb:74:in `report'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/runner.rb:115:in `run_specs'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/runner.rb:89:in `run'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/runner.rb:71:in `run'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/runner.rb:45:in `invoke'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.11.0/exe/rspec:4:in `<top (required)>'
# /home/yahonda/.rbenv/versions/3.1.1/bin/rspec:25:in `load'
# /home/yahonda/.rbenv/versions/3.1.1/bin/rspec:25:in `<top (required)>'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/site_ruby/3.1.0/bundler/cli/exec.rb:58:in `load'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/site_ruby/3.1.0/bundler/cli/exec.rb:58:in `kernel_load'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/site_ruby/3.1.0/bundler/cli/exec.rb:23:in `run'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/site_ruby/3.1.0/bundler/cli.rb:484:in `exec'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/site_ruby/3.1.0/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/site_ruby/3.1.0/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/site_ruby/3.1.0/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/site_ruby/3.1.0/bundler/cli.rb:31:in `dispatch'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/site_ruby/3.1.0/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/site_ruby/3.1.0/bundler/cli.rb:25:in `start'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/bundler-2.3.8/exe/bundle:48:in `block in <top (required)>'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/site_ruby/3.1.0/bundler/friendly_errors.rb:103:in `with_friendly_errors'
# /home/yahonda/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/bundler-2.3.8/exe/bundle:36:in `<top (required)>'
# /home/yahonda/.rbenv/versions/3.1.1/bin/bundle:25:in `load'
# /home/yahonda/.rbenv/versions/3.1.1/bin/bundle:25:in `<main>'
Finished in 0.59659 seconds (files took 0.42912 seconds to load)
1 example, 1 failure
Failed examples:
rspec ./spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:219 # OracleEnhancedAdapter structure dump structure dump should dump check constraints |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #2213