fixing to reuse the available function #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lserra-iov
reviewed
Nov 6, 2023
lserra-iov
previously approved these changes
Nov 8, 2023
ronaldsg20
force-pushed
the
fix/security-concern1
branch
2 times, most recently
from
47f9242 to
2d30bce
Compare
ronaldsg20
approved these changes
Nov 8, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
lserra-iov
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the security comment above:
Vadym Kolisnichenko commented:
Hey Alex Simas Braz ,
qq: do you know what was the reason to replace const estimatedFee = await getEstimatedFee(); with this calculation onst estimatedFee = pegoutQueueCount > 0 ? nextPegoutCost / pegoutQueueCount : 0; in actions.ts 22528d0#diff-677ba70779b5e66e7a47e4c6e9409baf147aa156a4bb85ad860a7dd152b26003L33