Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show default option #688

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Show default option #688

merged 2 commits into from
Apr 10, 2024

Conversation

lserra-iov
Copy link
Contributor

Show default option if flyover fails

alexjavabraz
alexjavabraz previously approved these changes Apr 5, 2024
Copy link
Collaborator

@alexjavabraz alexjavabraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexjavabraz alexjavabraz changed the base branch from flyover-pegout to main April 5, 2024 15:29
@alexjavabraz alexjavabraz dismissed their stale review April 5, 2024 15:29

The base branch was changed.

@alexjavabraz alexjavabraz changed the base branch from main to flyover-pegout April 5, 2024 15:51
Copy link
Collaborator

@alexjavabraz alexjavabraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@leoiovlabs leoiovlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lserra-iov lserra-iov force-pushed the fix/show-default-option branch from aace8ab to cd9b8c1 Compare April 9, 2024 16:02
Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
23.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@alexjavabraz alexjavabraz merged commit 50c2eee into flyover-pegout Apr 10, 2024
2 of 3 checks passed
@alexjavabraz alexjavabraz deleted the fix/show-default-option branch April 10, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants