Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base redesign #699

Merged
merged 121 commits into from
Aug 7, 2024
Merged

Base redesign #699

merged 121 commits into from
Aug 7, 2024

Conversation

lserra-iov
Copy link
Contributor

No description provided.

alexjavabraz
alexjavabraz previously approved these changes Apr 26, 2024
Copy link
Collaborator

@alexjavabraz alexjavabraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

annipi
annipi previously approved these changes Apr 29, 2024
Copy link
Contributor

@annipi annipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronaldsg20 ronaldsg20 changed the base branch from flyover-pegout to rebase/flyover-pegout May 3, 2024 17:29
@ronaldsg20 ronaldsg20 changed the base branch from rebase/flyover-pegout to flyover-pegout May 8, 2024 18:24
Base automatically changed from flyover-pegout to main May 16, 2024 15:58
@alexjavabraz alexjavabraz dismissed stale reviews from annipi and themself May 16, 2024 15:58

The base branch was changed.

annipi
annipi previously approved these changes Aug 6, 2024
ronaldsg20
ronaldsg20 previously approved these changes Aug 6, 2024
Copy link
Member

@ronaldsg20 ronaldsg20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronaldsg20 ronaldsg20 dismissed stale reviews from annipi and themself via 07af323 August 6, 2024 20:29
Copy link

sonarqubecloud bot commented Aug 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7 Security Hotspots
56.5% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Collaborator

@alexjavabraz alexjavabraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronaldsg20 ronaldsg20 merged commit 559bdcf into main Aug 7, 2024
6 of 7 checks passed
@ronaldsg20 ronaldsg20 deleted the base-redesign branch August 7, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants