Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings #896

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Remove warnings #896

merged 1 commit into from
Nov 18, 2024

Conversation

lserra-iov
Copy link
Contributor

Ignore register flyover call failures.
Add rejection errors.
Fix line length warning.

Copy link

github-actions bot commented Nov 7, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@@ -429,8 +429,7 @@ export default defineComponent({
.then(() => getFlyoverProviders())
.then(() => {
appendRecaptcha(flyoverService.value.siteKey);
})
.catch(console.error);
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be appropriately handled here.

Copy link
Collaborator

@alexjavabraz alexjavabraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@leoiovlabs leoiovlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annipi annipi merged commit 819cf7c into feature/2.3 Nov 18, 2024
3 of 4 checks passed
@annipi annipi deleted the fix/remove-warnings branch November 18, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants