Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable send button while getting quotes #917

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: disable send button while getting quotes #917

merged 1 commit into from
Nov 25, 2024

Conversation

annipi
Copy link
Contributor

@annipi annipi commented Nov 19, 2024 •
edited
Loading

TWPAPP-1004

  • Disabled Send button while there is valid no selected option
  • Disabled input for native option
  • Move recaptcha badge up so it does not cover buttons on the footer

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@annipi annipi self-assigned this Nov 19, 2024
@annipi annipi force-pushed the fix/disable-send branch 3 times, most recently from 7241c01 to dadbd10 Compare November 20, 2024 23:07
alexjavabraz
alexjavabraz approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@alexjavabraz alexjavabraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexjavabraz alexjavabraz mentioned this pull request Nov 21, 2024
Merged
leoiovlabs
leoiovlabs approved these changes Nov 22, 2024
View reviewed changes
Copy link

@leoiovlabs leoiovlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lserra-iov lserra-iov merged commit fc6f18a into feature/2.3 Nov 25, 2024
4 checks passed
@lserra-iov lserra-iov deleted the fix/disable-send branch November 25, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lserra-iov lserra-iov lserra-iov approved these changes

@leoiovlabs leoiovlabs leoiovlabs approved these changes

@alexjavabraz alexjavabraz alexjavabraz approved these changes

Assignees

@annipi annipi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annipi @alexjavabraz @leoiovlabs @lserra-iov