Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: do not show countdown while a transaction is being processed #979

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Fix: do not show countdown while a transaction is being processed #979

merged 2 commits into from
Dec 23, 2024

Conversation

annipi
Copy link
Contributor

@annipi annipi commented Dec 18, 2024 •
edited
Loading

TWPAPP-1037

Screenshot 2024-12-18 at 2 30 32 PM Screenshot 2024-12-18 at 5 11 16 PM

Review conditions:

Screenshot 2024-12-20 at 3 02 59 PM

@annipi annipi changed the base branch from main to feature/2.3 December 18, 2024 22:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@annipi annipi self-assigned this Dec 18, 2024
@annipi annipi force-pushed the fix/countdown branch 2 times, most recently from e291cc8 to 7664ba3 Compare December 18, 2024 22:26
ronaldsg20
ronaldsg20 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@ronaldsg20 ronaldsg20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annipi annipi marked this pull request as draft December 20, 2024 21:19
@annipi annipi marked this pull request as ready for review December 20, 2024 21:31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@annipi annipi merged commit 4357058 into feature/2.3 Dec 23, 2024
5 checks passed
@annipi annipi deleted the fix/countdown branch December 23, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lserra-iov lserra-iov lserra-iov approved these changes

@ronaldsg20 ronaldsg20 ronaldsg20 approved these changes

Assignees

@annipi annipi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annipi @ronaldsg20 @lserra-iov