Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Liquality #339

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Remove Liquality #339

merged 1 commit into from
Sep 17, 2024

Conversation

ronaldsg20
Copy link
Member 

	I've updated the `checkRloginInjectedProviders` method in order
	to ensure the Liquality injected provider will be removed from
	the web3modal providers return.

@ronaldsg20
Remove Liquality
31e026e 
		I've updated the checkRloginInjectedProviders method in order
		to ensure the Liquality injected provider will be removed from
		the web3modal providers return.
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

annipi
annipi approved these changes Aug 29, 2024
View reviewed changes
Copy link

@annipi annipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Freshenext
Freshenext approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@Freshenext Freshenext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We spoke in persona in the hub meetings. The reason is that liquality is no longer maintained and supported. An article will be pasted here so that we know the reason for this merge.

Pending Ronald to put it.

Btw code changes are OK.

jessgusclark
jessgusclark requested changes Sep 11, 2024
View reviewed changes
Copy link
Member

@jessgusclark jessgusclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to WalletProviders.tsx is good, but I don't understand the change to injectedProvider.

src/providers/injectedProviders.ts Show resolved Hide resolved
@alexjavabraz alexjavabraz merged commit 87550f2 into rsksmart:develop Sep 17, 2024
3 checks passed
@ronaldsg20 ronaldsg20 deleted the refactor/remove-liquality branch September 17, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessgusclark jessgusclark jessgusclark requested changes

@annipi annipi annipi approved these changes

@Freshenext Freshenext Freshenext approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronaldsg20 @jessgusclark @annipi @Freshenext @alexjavabraz