-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settup and add initial svp tests. #200
Open
jeremy-then
wants to merge
6
commits into
svp-integration
Choose a base branch
from
setup-svp-tests
base: svp-integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c5f6867
Settup and add initial svp tests.
jeremy-then 1c08eb9
Asserting events.
jeremy-then 9997ec4
Asserting output value.
jeremy-then 773b3b7
Fix typos
jeremy-then fc1551b
Renames variable
jeremy-then ad6dc39
Renames test
jeremy-then File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
var fs = require('fs-extra'); | ||
var utils = require('peglib').utils; | ||
const RLP = require('rlp'); | ||
|
||
var sequentialPromise = function(n, promiseReturn) { | ||
if (n <= 0) { | ||
|
@@ -160,6 +161,37 @@ function splitStringIntoChunks(inputString, chunkSize) { | |
return inputString.match(regex); | ||
} | ||
|
||
const bytesToHexString = (bytes) => { | ||
return bytes.reduce((str, byte) => str + byte.toString(16).padStart(2, '0'), ''); | ||
}; | ||
|
||
const removeEmptyLeftBytes = (storageValue) => { | ||
const result = `${storageValue.replaceAll(/^0x0+/g, '')}`; | ||
if(!result.startsWith('0x')) { | ||
return `0x${result}`; | ||
} | ||
return result; | ||
}; | ||
|
||
const decodeRlp = (rlpEncoded) => { | ||
const uint8ArrayDecoded = RLP.decode(rlpEncoded); | ||
const bytesStr = bytesToHexString(uint8ArrayDecoded); | ||
return bytesStr; | ||
}; | ||
|
||
const getBridgeStorageValueDecodedHexString = (bridgeStorageValueEncodedAsRlp, append0xPrefix = true) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we implemented this in one of our libraries didn't we? Might be a good idea anyway to have maybe a specialized library that reads values from the Bridge storage |
||
const rlpBytesWithoutEmptyBytes = removeEmptyLeftBytes(bridgeStorageValueEncodedAsRlp); | ||
const decodedHexFromRlp = decodeRlp(rlpBytesWithoutEmptyBytes); | ||
return append0xPrefix ? `0x${decodedHexFromRlp}` : decodedHexFromRlp; | ||
}; | ||
|
||
const getBridgeStorageIndexFromKey = (storageKey) => { | ||
return Buffer.from(storageKey) | ||
.toString('hex') | ||
.padStart(64, '0') | ||
.padStart(66, '0x'); | ||
}; | ||
|
||
module.exports = { | ||
sequentialPromise, | ||
mapPromiseAll, | ||
|
@@ -180,4 +212,9 @@ module.exports = { | |
remove: removeAdditionalFederationAddress | ||
}, | ||
splitStringIntoChunks, | ||
bytesToHexString, | ||
removeEmptyLeftBytes, | ||
decodeRlp, | ||
getBridgeStorageValueDecodedHexString, | ||
getBridgeStorageIndexFromKey, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
const extendWeb3WithRskModule = (web3) => { | ||
web3.extend({ | ||
property: 'rsk', | ||
methods: [{ | ||
name: 'getStorageBytesAt', | ||
call: 'rsk_getStorageBytesAt', | ||
params: 3, | ||
inputFormatter: [web3.extend.formatters.inputAddressFormatter, web3.extend.formatters.inputDefaultBlockNumberFormatter, web3.extend.formatters.inputDefaultBlockNumberFormatter] | ||
}] | ||
}); | ||
}; | ||
|
||
module.exports = { | ||
extendWeb3WithRskModule, | ||
}; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of using powpeg-details library?
Not now, but if you think it's a good idea we can add it in a separate PR