Fix:Refactor vote function to follow CEI pattern #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the vote() function to correctly follow the Checks-Effects-Interactions (CEI) security pattern.
Change
I have reordered the statements within the function to perform all state updates before the external call to votingTokenContract.transferFrom().
importance
This is a fundamental security measure that prevents potential re-entrancy attacks and other unexpected state-related bugs. While the contract uses a re-entrancy guard, adhering to the CEI pattern provides a crucial layer of defense-in-depth.
This change makes the contract safer and more robust without altering its core functionality.