fmacleal/integrate tstorage in transaction execution #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
- WIP - Now we will add unit tests for underflow execution tests
fmacleal
force-pushed
the
fmacleal/integrate-tstorage-in-transaction-execution
branch
from
2b12be5 to
61a3a23
Compare
- We had to add unit tests for underflow execution tests since isn't possible write contract for these scenarios - Now we have all the tests regarding execution context with different types of calls, missing the gas cost calculation that will be done in a later task
fmacleal
changed the title
asoto-iov
approved these changes
Nov 13, 2024
Vovchyk
reviewed
Nov 14, 2024
|
fmacleal
merged commit ea7d304
into
fmacleal/addition_transient_storage_opcodes
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this MR,
We are adding the TLOAD and TSTORE opcodes in the transaction execution context, validating that the transient storage it's using the memory context correctly between different contract calls. More specifically, if we use
delegatecall,callcode,callandstaticcallthe values stored between these different contracts subcalls are storing and loading the values as defined by the EIP-1153 . This way, we will ensure that no contract it's accessing the memory from the other regarding the context call used.Besides this, I have addressed some sonar issues regarding the use of switchcase in the opcodes classes.
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: