Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logging): add logs to FilterManager class #2908

Merged
merged 1 commit into from
Jan 28, 2025
Merged

feat(logging): add logs to FilterManager class #2908

merged 1 commit into from
Jan 28, 2025

Conversation

Vovchyk
Copy link
Contributor

@Vovchyk Vovchyk commented Dec 27, 2024

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

rmoreliovlabs
rmoreliovlabs approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@rmoreliovlabs rmoreliovlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fmacleal
fmacleal approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@fmacleal fmacleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vovchyk Vovchyk force-pushed the vovchyk/extra-logs-for-filter-changes branch from 2a49a96 to 1d5d1fd Compare January 28, 2025 12:02
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
69.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Vovchyk Vovchyk merged commit 79079e9 into master Jan 28, 2025
13 checks passed
@Vovchyk Vovchyk deleted the vovchyk/extra-logs-for-filter-changes branch January 28, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmacleal fmacleal fmacleal approved these changes

@rmoreliovlabs rmoreliovlabs rmoreliovlabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vovchyk @rmoreliovlabs @fmacleal