Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing validation of tx size according the max size allowed for a tx #2984

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

fmacleal
Copy link
Contributor

@fmacleal fmacleal commented Feb 6, 2025

Description

Before, we were allowing a transaction length bigger than the max allowed.
This commit fixes it and add a test to validate.

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

Before, we were allowing a transaction length bigger than the max allowed. This commit fixes it and add a test to validate.
Copy link

github-actions bot commented Feb 6, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

nagarev
nagarev previously approved these changes Feb 7, 2025
Copy link
Contributor

@nagarev nagarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really loved the refactor! beautiful new test! I only left a minor comment for you to consider and decide.

Vovchyk
Vovchyk previously approved these changes Feb 10, 2025
@fmacleal fmacleal dismissed stale reviews from Vovchyk and nagarev via ea85c92 February 10, 2025 12:15
@Vovchyk Vovchyk merged commit 8e6729d into master Feb 11, 2025
12 checks passed
@Vovchyk Vovchyk deleted the fmacleal/fix-cpu-waste-of-resources branch February 11, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants