Skip to content

hsm signing service, refactor for TransactionSender signing functions. #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

hsm signing service, refactor for TransactionSender signing functions. #218

wants to merge 3 commits into from

Conversation

@mauri-rsk
Copy link
Contributor

@mauri-rsk mauri-rsk commented Jun 7, 2021

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Jun 7, 2021

This pull request introduces 2 alerts when merging 5be5c26 into 82168ef - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class
  • 1 for Missing await

pmprete
pmprete reviewed Jun 7, 2021
View reviewed changes
Copy link
Contributor

@pmprete pmprete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except my comments looks good

@lgtm-com
Copy link

lgtm-com bot commented Jun 7, 2021

This pull request introduces 1 alert when merging 68dd90e into 82168ef - view on LGTM.com

new alerts:

  • 1 for Missing await

@lgtm-com
Copy link

lgtm-com bot commented Jun 9, 2021

This pull request introduces 1 alert when merging 003d9a3 into 82168ef - view on LGTM.com

new alerts:

  • 1 for Missing await

@pmprete pmprete force-pushed the 2.0.0-rebased branch 2 times, most recently from 200481e to 838f986 Compare June 21, 2021 22:02
Base automatically changed from 2.0.0-rebased to master July 19, 2021 15:05
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 24 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 58 Code Smells

No Coverage information No Coverage information
2.8% 2.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 New Blocker Issues (required ≤ 0)
28 New Critical Issues (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pmprete pmprete pmprete left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

do not merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mauri-rsk @pmprete