rsl::format #15
Open
rsl::format #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaraslaut
reviewed
Sep 11, 2025
Comment on lines
+10
to
+14
| # add_executable(example_review | ||
| # review.cpp | ||
| # review_tu2.cpp | ||
| # ) | ||
| # target_link_libraries(example_review PRIVATE rsl_util) |
There was a problem hiding this comment.
maybe just remove it, no need for keeping commented out code
There was a problem hiding this comment.
oh, I should probably re-enable that. I think something there broke, gonna take a look in a different PR
Comment on lines
+45
to
+48
| [[nodiscard]] std::string with_style(StyleMap const& style) const { | ||
| return (this->*join)(&style); | ||
| } | ||
| [[nodiscard]] std::string unstyled() const { return (this->*join)(nullptr); } |
There was a problem hiding this comment.
I guess better to have more consistent naming, if we have with_style than unstyled should be without_style, or the with_style should become styled
| } | ||
|
|
||
| if (!consume(']')) { | ||
| // std::println("missing closing ]"); |
Comment on lines
+21
to
+27
| consteval explicit operator std::meta::info() const { | ||
| auto args = std::vector<rsl::string_view>(); | ||
| for (auto const& tag : tags) { | ||
| args.emplace_back(std::define_static_string(tag)); | ||
| } | ||
| return std::meta::reflect_constant(Tag{std::define_static_array(args), enable}); | ||
| } |
Comment on lines
+11
to
+13
| std::vector<std::string_view> names = nonstatic_data_members_of(type, std::meta::access_context::current()) | | ||
| std::views::transform(std::meta::identifier_of) | | ||
| std::ranges::to<std::vector>(); |
There was a problem hiding this comment.
hm, will this get cached for the same type as with template instantiation or this will be evaluated every time ?
| {"magenta", "\x1b[35m"}, | ||
| { "cyan", "\x1b[36m"}, | ||
| { "white", "\x1b[37m"}, | ||
| {"default", "\x1b[3m8"} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.